Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert cri-o freeze #1343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert cri-o freeze #1343

wants to merge 2 commits into from

Conversation

akalenyu
Copy link
Contributor

What this PR does / why we need it:
Once the cri-o issues are fixed, we should continue consuming latest cri-o.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 30, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign brianmcarey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akalenyu
Copy link
Contributor Author

/hold

/cc @enp0s3 @brianmcarey
@haircommander @giuseppe do you happen to know whether https://issues.redhat.com/browse/OCPBUGS-45394 is fixed in 1.31.3?

@kubevirt-bot kubevirt-bot requested a review from enp0s3 December 30, 2024 16:18
@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2024
@brianmcarey
Copy link
Member

/retest

@haircommander
Copy link

so the fix should be in crun, so any cri-o version should work given the correct crun version (1.19)

@akalenyu
Copy link
Contributor Author

akalenyu commented Jan 2, 2025

so the fix should be in crun, so any cri-o version should work given the correct crun version (1.19)

@brianmcarey I believe we're consuming crun through the cri-o install? and that does not have 1.19 yet

@haircommander
Copy link

ah gotcha. 1.31.1 does not have an updated crun. I am trying to figure out a bug I've introduced and once I do that i'll cut a 1.31.2 which will have new crun

@enp0s3
Copy link
Contributor

enp0s3 commented Jan 3, 2025

@haircommander Hi, if for example we want to consume latest CRIO with latest crun, is there DNF repo that contains nightly RPMs of latest CRIO and crun builds?

@enp0s3
Copy link
Contributor

enp0s3 commented Jan 3, 2025 •
edited
Loading

@ormergi Hi, do you know if there was a progress since CRIO was pinned? AFAIK it were the network tests that failed to create the network tap device.
We would benefit from investing time researching this issue and remove the CRI-O pinning, since we've missed important breaking change that caused disk hotplug to break, it was revealed first in D/S, while it shouldn't.

@enp0s3
Copy link
Contributor

enp0s3 commented Jan 3, 2025

@ormergi Sorry I've missed that @akalenyu pointed out https://issues.redhat.com/browse/OCPBUGS-45394
It looks like it should fix the network tests

@brianmcarey
Copy link
Member

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@kubevirt-bot kubevirt-bot added size/XS and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S labels Jan 14, 2025
@akalenyu
Copy link
Contributor Author

ah gotcha. 1.31.1 does not have an updated crun. I am trying to figure out a bug I've introduced and once I do that i'll cut a 1.31.2 which will have new crun

I believe you meant 1.31.4? I am looking at latest dnf install -y cri-o which is 1.31.3 and that has crun 1.18.2
which I believe does not have

cgroup, systemd: do not override devices on update. If the "update" request has no device block configured, do not reset the previously configuration.

(only in crun 1.19 according to release notes)

# /usr/libexec/crio/crun --version
crun version 1.18.2

@kubevirt-bot
Copy link
Contributor

@akalenyu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-sriov 94883af link false /test check-up-kind-sriov
check-provision-k8s-1.32 94883af link true /test check-provision-k8s-1.32
check-provision-k8s-1.30 94883af link true /test check-provision-k8s-1.30
check-provision-k8s-1.31-s390x 94883af link true /test check-provision-k8s-1.31-s390x
check-provision-k8s-1.31 94883af link true /test check-provision-k8s-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

@oshoval oshoval Awaiting requested review from oshoval

@enp0s3 enp0s3 Awaiting requested review from enp0s3

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akalenyu @kubevirt-bot @brianmcarey @haircommander @enp0s3